[Logs SDK] Deprecate LogData struct #2325
Merged
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Nov 22, 2024
| @@ -13,6 +13,10 @@ pub use log_processor::{ | |||
| use opentelemetry::InstrumentationScope; | |||
| pub use record::{LogRecord, TraceContext}; | |||
|
|
|||
| #[deprecated( | |||
cijothomas
approved these changes
Nov 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2325 +/- ##
=====================================
Coverage 79.5% 79.5%
=====================================
Files 123 123
Lines 21258 21258
=====================================
Hits 16907 16907
Misses 4351 4351 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
utpilla
approved these changes
Nov 22, 2024
|
More CI failuares due to recent rustls version updates. Maybe after patch release, we should bump msrv version for api and sdk from 1.70.0 to 1.71.0. For now, will create a msrv patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The struct is not used anywhere, and can be deprecated, and later removed in next major release.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes